From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZT5l-0006v6-59
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:51:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZT5g-0006nD-SA
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:51:12 -0500
Received: from [199.232.76.173] (port=48413 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZT5g-0006mz-Mx
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:51:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6983)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NZT5g-0006l6-5T
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:51:08 -0500
Date: Mon, 25 Jan 2010 19:47:56 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld
Message-ID: <20100125174756.GB11998@redhat.com>
References: <1264368221-3040-1-git-send-email-hpoussin@reactos.org>
	<20100125100905.GA9019@redhat.com>
	<4B5DD596.4040503@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B5DD596.4040503@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Herve Poussineau <hpoussin@reactos.org>, qemu-devel@nongnu.org, lcapitulino@redhat.com

On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Sun, Jan 24, 2010 at 09:23:41PM +0000, Herve Poussineau wrote:
> >> Replace %lld occurrences by PRId64.
> >
> > This is wrong.
> > long long values should be printed with %lld.
> > size_t - with %zd. PRId64 is for int64_t.
> >
> 
> size_t => %zu, ssize_t => %zd might be better.
> 
> And none of them works on win32, so using them
> there can result in a crash:
> 
>     size_t st = 4711;
>     fprintf(stderr, "st=%zu, %s\n", st, "test");
> 
> printf functions on win32 don't know %z.
> They run
> 
>     fprintf(stderr, "st=zu, %s\n", st, "test");
> 
> which results in an memory access fault when printf
> wants to read the memory at address 0x4711.
> 
> Regards,
> Stefan Weil

Let's just implement a compliant printf?