From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZhbo-0001Ix-LE for qemu-devel@nongnu.org; Tue, 26 Jan 2010 04:21:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZhbi-0001CO-4O for qemu-devel@nongnu.org; Tue, 26 Jan 2010 04:21:15 -0500 Received: from [199.232.76.173] (port=33130 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZhbh-0001C5-OL for qemu-devel@nongnu.org; Tue, 26 Jan 2010 04:21:09 -0500 Received: from verein.lst.de ([213.95.11.210]:60293) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NZhbh-0007bH-3S for qemu-devel@nongnu.org; Tue, 26 Jan 2010 04:21:09 -0500 Date: Tue, 26 Jan 2010 10:21:04 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs Message-ID: <20100126092104.GA21528@lst.de> References: <20100119211539.GA4383@lst.de> <4B56EB0F.2020409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B56EB0F.2020409@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christoph Hellwig , qemu-devel@nongnu.org On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: > To underline that it's a backend/platform dependent thing: Your patch > breaks the mingw build for me. Actually that's because mingw is the usual piece of crap and doesn't actually have any of the vector support you can expect from a normal Unix system. I can either throw in an #ifdef IOV_MAX around the check or fake one up for mingw. Does any of the maintainers have a preference for either variant?