From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZkLm-0002s8-7H
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:16:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZkLh-0002py-7G
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:16:53 -0500
Received: from [199.232.76.173] (port=32782 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZkLh-0002pq-2l
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:16:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49120)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NZkLg-0000E1-LU
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:16:48 -0500
Date: Tue, 26 Jan 2010 10:16:34 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100126101634.1797afed@doriath>
In-Reply-To: <1264443524.2890.3.camel@aglitke>
References: <1264443524.2890.3.camel@aglitke>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] New API for asynchronous monitor commands
	(V2)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Mon, 25 Jan 2010 12:18:44 -0600
Adam Litke <agl@us.ibm.com> wrote:

> Changes since V1:
>  - Miscellaneous code cleanups (Thanks Luiz)
> 
> Qemu has a number of commands that can operate asynchronously (savevm, migrate,
> etc) and it will be getting more.  For these commands, the user monitor needs
> to be suspended, but QMP monitors could continue to to accept other commands.
> This patch introduces a new command API that isolates the details of handling
> different monitor types from the actual command execution.
> 
> A monitor command can use this API by implementing the mhandler.cmd_async
> handler (or info_async if appropriate).  This function is responsible for
> submitting the command and does not return any data although it may raise
> errors.  When the command completes, the QMPCompletion callback should be
> invoked with its opaque data and the command result.
> 
> The process for submitting and completing an asynchronous command is different
> for QMP and user monitors.  A user monitor must be suspended at submit time and
> resumed at completion time.  The user_print() function must be passed to the
> QMPCompletion callback so the result can be displayed properly.  QMP monitors
> are simpler.  No submit time setup is required.  When the command completes,
> monitor_protocol_emitter() writes the result in JSON format.

 s/QMPCompletion/MonitorCompletion

 Otherwise looks good to me.