From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZkrt-0000iI-Rs
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:50:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZkro-0000dv-LU
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:50:04 -0500
Received: from [199.232.76.173] (port=57502 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZkro-0000dn-6I
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:50:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61755)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NZkrn-0004HB-Nq
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 07:49:59 -0500
Date: Tue, 26 Jan 2010 14:46:42 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld
Message-ID: <20100126124642.GB19036@redhat.com>
References: <1264368221-3040-1-git-send-email-hpoussin@reactos.org>
	<20100125100905.GA9019@redhat.com>
	<20100125120348.461ce622@doriath>
	<m3k4v6s14m.fsf@blackfin.pond.sub.org>
	<20100125132719.23a483cf@doriath>
	<20100125153838.GB11161@redhat.com>
	<20100126094329.70719b6f@doriath>
	<4B5EE450.9090004@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B5EE450.9090004@linux.vnet.ibm.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Herve Poussineau <hpoussin@reactos.org>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Tue, Jan 26, 2010 at 06:47:12AM -0600, Anthony Liguori wrote:
> On 01/26/2010 05:43 AM, Luiz Capitulino wrote:
>>> The issue I see isn't related to unsigned.  Apparently we currently
>>> accept values such as 'a' as valid strings. Since this is not valid json
>>> we probably should reject it just in case we will want to switch to
>>> another json library, otherwise clients might come to depend on
>>> non-standard behaviour.
>>>      
>>   This extension is only used internally by QEMU and we find it
>> very convenient otherwise we would have to escape strings in
>> dicts and lists, which is error prone and time consuming.
>>    
>
> Actually, I was reading the JSON RFC last night and came across:
>
>   "A JSON parser transforms a JSON text into another representation. A
>    JSON parser MUST accept all texts that conform to the JSON grammar.
>    A JSON parser MAY accept non-JSON forms or extensions."
>
> So we are fully JSON compliant in our current implementation.
>
> Regards,
>
> Anthony Liguori

Yes, I agree we are comnpliant.
But I also think we should be strict and reject non-JSON
input just so that clients do not come to depend on it.

-- 
MST