From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZlgS-0005uM-CS for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:42:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZlgN-0005qD-JU for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:42:19 -0500 Received: from [199.232.76.173] (port=46928 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZlgN-0005q6-BX for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:42:15 -0500 Received: from verein.lst.de ([213.95.11.210]:49561) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NZlgM-0003H3-Re for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:42:15 -0500 Date: Tue, 26 Jan 2010 14:42:10 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs Message-ID: <20100126134210.GA1644@lst.de> References: <20100119211539.GA4383@lst.de> <4B56EB0F.2020409@redhat.com> <20100126092104.GA21528@lst.de> <4B5EE944.9050602@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B5EE944.9050602@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Christoph Hellwig , qemu-devel@nongnu.org On Tue, Jan 26, 2010 at 07:08:20AM -0600, Anthony Liguori wrote: > >I can either throw in an #ifdef IOV_MAX around the check or fake one up > >for mingw. Does any of the maintainers have a preference for either > >variant? > > > > grep for CONFIG_IOVEC in qemu-common.h and add a #define IOV_MAX. > > mingw doesn't have iovec so we introduce a compat version. Yes, that's what I meant with the second alternative above.