From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NaDuL-0002XY-VQ
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NaDuG-0002Wj-JP
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:33 -0500
Received: from [199.232.76.173] (port=36053 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NaDuG-0002Wg-GC
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20514)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NaDuF-0000R1-TH
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:28 -0500
Date: Wed, 27 Jan 2010 21:47:17 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2-repost 1/3] qemu: memory notifiers
Message-ID: <20100127194715.GA4338@redhat.com>
References: <cover.1264429651.git.mst@redhat.com>
	<20100125142912.GB11154@redhat.com>
	<4B5F75BF.1050005@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B5F75BF.1050005@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, gleb@redhat.com, avi@redhat.com

On Tue, Jan 26, 2010 at 05:07:43PM -0600, Anthony Liguori wrote:
> On 01/25/2010 08:29 AM, Michael S. Tsirkin wrote:
>> This adds notifiers for phys memory changes: a set of callbacks that
>> vhost can register and update kernel accordingly.  Down the road, kvm
>> code can be switched to use these as well, instead of calling kvm code
>> directly from exec.c as is done now.
>>
>> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>> Acked-by: Avi Kivity<avi@redhat.com>
>>    
>
> This breaks the linux-user build (exec.o: cpu_notify_set_memory defined  
> but not used).
>
> Regards,
>
> Anthony Liguori

Ugh, this will fix it. Want me to repost the series?

diff --git a/exec.c b/exec.c
index 63caca0..2e7434e 100644
--- a/exec.c
+++ b/exec.c
@@ -1623,6 +1623,7 @@ const CPULogItem cpu_log_items[] = {
     { 0, NULL, NULL },
 };
 
+#ifndef CONFIG_USER_ONLY
 static QLIST_HEAD(memory_client_list, CPUPhysMemoryClient) memory_client_list
     = QLIST_HEAD_INITIALIZER(memory_client_list);
 
@@ -1715,6 +1716,7 @@ void cpu_unregister_phys_memory_client(CPUPhysMemoryClient *client)
 {
     QLIST_REMOVE(client, list);
 }
+#endif
 
 static int cmp1(const char *s1, int n, const char *s2)
 {