From: Christoph Hellwig <hch@lst.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] block: avoid creating too large iovecs in multiwrite_merge
Date: Mon, 1 Feb 2010 09:28:11 +0100 [thread overview]
Message-ID: <20100201082811.GA19570@lst.de> (raw)
In-Reply-To: <4B5F83D1.3000101@codemonkey.ws>
On Tue, Jan 26, 2010 at 06:07:45PM -0600, Anthony Liguori wrote:
> On 01/26/2010 07:49 AM, Christoph Hellwig wrote:
> >If we go over the maximum number of iovecs support by syscall we get
> >back EINVAL from the kernel which translate to I/O errors for the guest.
> >
> >Add a MAX_IOV defintion for platforms that don't have it. For now we use
> >the same 1024 define that's used on Linux and various other platforms,
> >but until the windows block backend implements some kind of vectored I/O
> >it doesn't matter.
> >
> >Signed-off-by: Christoph Hellwig<hch@lst.de>
> >
>
> Applied. Thanks.
Can you also add it to the 0.12-stable series? There's tons of bug
reports from users seeing this regression in qemu-0.12.
prev parent reply other threads:[~2010-02-01 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 13:49 [Qemu-devel] [PATCH v2] block: avoid creating too large iovecs in multiwrite_merge Christoph Hellwig
2010-01-27 0:07 ` Anthony Liguori
2010-02-01 8:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201082811.GA19570@lst.de \
--to=hch@lst.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).