From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nbrdy-0000dH-El for qemu-devel@nongnu.org; Mon, 01 Feb 2010 03:28:27 -0500 Received: from [199.232.76.173] (port=42600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nbrdv-0000cc-Vf for qemu-devel@nongnu.org; Mon, 01 Feb 2010 03:28:24 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nbrdt-0003F7-PG for qemu-devel@nongnu.org; Mon, 01 Feb 2010 03:28:23 -0500 Received: from mx20.gnu.org ([199.232.41.8]:35049) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nbrdt-0003Ev-DD for qemu-devel@nongnu.org; Mon, 01 Feb 2010 03:28:21 -0500 Received: from verein.lst.de ([213.95.11.210]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nbrdr-0006yX-SQ for qemu-devel@nongnu.org; Mon, 01 Feb 2010 03:28:20 -0500 Date: Mon, 1 Feb 2010 09:28:11 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH v2] block: avoid creating too large iovecs in multiwrite_merge Message-ID: <20100201082811.GA19570@lst.de> References: <20100126134908.GA1883@lst.de> <4B5F83D1.3000101@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B5F83D1.3000101@codemonkey.ws> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Christoph Hellwig , qemu-devel@nongnu.org On Tue, Jan 26, 2010 at 06:07:45PM -0600, Anthony Liguori wrote: > On 01/26/2010 07:49 AM, Christoph Hellwig wrote: > >If we go over the maximum number of iovecs support by syscall we get > >back EINVAL from the kernel which translate to I/O errors for the guest. > > > >Add a MAX_IOV defintion for platforms that don't have it. For now we use > >the same 1024 define that's used on Linux and various other platforms, > >but until the windows block backend implements some kind of vectored I/O > >it doesn't matter. > > > >Signed-off-by: Christoph Hellwig > > > > Applied. Thanks. Can you also add it to the 0.12-stable series? There's tons of bug reports from users seeing this regression in qemu-0.12.