From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nby4J-0005tW-6e for qemu-devel@nongnu.org; Mon, 01 Feb 2010 10:20:03 -0500 Received: from [199.232.76.173] (port=42779 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nby4I-0005tC-Id for qemu-devel@nongnu.org; Mon, 01 Feb 2010 10:20:02 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nby4G-0002M4-GS for qemu-devel@nongnu.org; Mon, 01 Feb 2010 10:20:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5732) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nby4G-0002Lm-5L for qemu-devel@nongnu.org; Mon, 01 Feb 2010 10:20:00 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o11FJwaA014226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Feb 2010 10:19:59 -0500 Date: Mon, 1 Feb 2010 13:19:50 -0200 From: Luiz Capitulino Message-ID: <20100201131950.381cd455@doriath> In-Reply-To: <20100201151210.GA9453@redhat.com> References: <20100201151210.GA9453@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] monitor: fix crash at info pci List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Mon, 1 Feb 2010 17:12:11 +0200 "Michael S. Tsirkin" wrote: > info pci returns a bus object, not a qdict, which leads to a crash in > monitor which wants a qdict. Not sure what the right fix is: this patch > just checks and handles non-disct command as synchronous. OTOH if we > definitely need all commands to return a dict, we should change return > type appropriately. This has already been fixed by commit 82617d7, thanks anyway :)