From: "Michael S. Tsirkin" <mst@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] monitor: fix crash at info pci\
Date: Mon, 1 Feb 2010 18:11:22 +0200 [thread overview]
Message-ID: <20100201161122.GA10751@redhat.com> (raw)
In-Reply-To: <20100201131950.381cd455@doriath>
On Mon, Feb 01, 2010 at 01:19:50PM -0200, Luiz Capitulino wrote:
> On Mon, 1 Feb 2010 17:12:11 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > info pci returns a bus object, not a qdict, which leads to a crash in
> > monitor which wants a qdict. Not sure what the right fix is: this patch
> > just checks and handles non-disct command as synchronous. OTOH if we
> > definitely need all commands to return a dict, we should change return
> > type appropriately.
>
> This has already been fixed by commit 82617d7, thanks anyway :)
Yes, fixed now.
prev parent reply other threads:[~2010-02-01 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 15:12 [Qemu-devel] [PATCH] monitor: fix crash at info pci Michael S. Tsirkin
2010-02-01 15:19 ` [Qemu-devel] " Luiz Capitulino
2010-02-01 16:11 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201161122.GA10751@redhat.com \
--to=mst@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).