From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nbyv6-0001GN-LV
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 11:14:36 -0500
Received: from [199.232.76.173] (port=45525 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nbyv6-0001GC-5q
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 11:14:36 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1Nbyv5-0005oO-6P
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 11:14:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57175)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Nbyv4-0005oG-QT
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 11:14:35 -0500
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o11GEXrq024869
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 1 Feb 2010 11:14:34 -0500
Date: Mon, 1 Feb 2010 18:11:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100201161122.GA10751@redhat.com>
References: <20100201151210.GA9453@redhat.com>
	<20100201131950.381cd455@doriath>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100201131950.381cd455@doriath>
Subject: [Qemu-devel] Re: [PATCH] monitor: fix crash at info pci\
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Feb 01, 2010 at 01:19:50PM -0200, Luiz Capitulino wrote:
> On Mon, 1 Feb 2010 17:12:11 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > info pci returns a bus object, not a qdict, which leads to a crash in
> > monitor which wants a qdict.  Not sure what the right fix is: this patch
> > just checks and handles non-disct command as synchronous.  OTOH if we
> > definitely need all commands to return a dict, we should change return
> > type appropriately.
> 
>  This has already been fixed by commit 82617d7, thanks anyway :)

Yes, fixed now.