From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nc0kU-0007b8-Nb
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 13:11:46 -0500
Received: from [199.232.76.173] (port=57614 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nc0kU-0007as-Al
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 13:11:46 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nc0kT-0007ID-18
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 13:11:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1546)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nc0kS-0007Hz-If
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 13:11:44 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o11IBhgi007173
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 1 Feb 2010 13:11:43 -0500
Date: Mon, 1 Feb 2010 16:11:27 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command
Message-ID: <20100201161127.0de054f9@doriath>
In-Reply-To: <m3ock8nb0b.fsf@blackfin.pond.sub.org>
References: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>
	<1264686180-29845-5-git-send-email-lcapitulino@redhat.com>
	<m3ock8nb0b.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 01 Feb 2010 18:04:04 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > It will be used to switch between "handshake" and "operational"
> > modes. Currently it doesn't have any practical effect, as
> > mode-oriented support is not enforced yet.
> >
> > Usage example:
> >
> > { "execute": "qmp_switch_mode", "arguments": { "mode": "operational" } }
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  monitor.c       |   26 ++++++++++++++++++++++++++
> >  qemu-monitor.hx |   15 +++++++++++++++
> >  2 files changed, 41 insertions(+), 0 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index 3ced51d..f6dd64d 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -704,6 +704,32 @@ static void do_info_qmp_mode(Monitor *mon, QObject **ret_data)
> >      *ret_data = qobject_from_jsonf("{ 'mode': %s }", mode);
> >  }
> >  
> > +static void do_qmp_switch_mode(Monitor *mon, const QDict *qdict,
> > +                               QObject **ret_data)
> > +{
> > +    const char *mode;
> > +
> > +    if (!monitor_ctrl_mode(mon)) {
> > +        return;
> > +    }
> 
> So the command "qmp_switch_mode" is available in the human monitor, but
> does nothing?
> 
> What about a flag "QMP only?"

 Seems reasonable, I only have to check if the work it requires is
related to this series.