From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NcdOm-00044o-Sb
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 06:27:56 -0500
Received: from [199.232.76.173] (port=47151 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NcdOl-00043x-SG
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 06:27:55 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1NcdOK-0001bq-3g
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 06:27:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22029)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NcdOJ-0001bc-8I
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 06:27:27 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o13BRPdH022049
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 3 Feb 2010 06:27:25 -0500
Date: Wed, 3 Feb 2010 09:27:15 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100203092715.1e3cb78e@doriath>
In-Reply-To: <4B693F6D.5090300@redhat.com>
References: <1265145013-23231-1-git-send-email-lcapitulino@redhat.com>
	<1265145013-23231-2-git-send-email-lcapitulino@redhat.com>
	<4B693F6D.5090300@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 03 Feb 2010 10:18:37 +0100
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 02.02.2010 22:10, schrieb Luiz Capitulino:
> > This commit adds the basic definitions for the BLOCK_IO_ERROR
> > event, but actual event emission will be introduced by the
> > next commits.
> > 
> > NOTE: Adding a small reference in QMP/qmp-events.txt, but this
> > file is wrong and will be replaced by proper documentation shortly.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  QMP/qmp-events.txt |    7 +++++++
> >  monitor.c          |    3 +++
> >  monitor.h          |    1 +
> >  3 files changed, 11 insertions(+), 0 deletions(-)
> > 
> > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> > index dc48ccc..7886192 100644
> > --- a/QMP/qmp-events.txt
> > +++ b/QMP/qmp-events.txt
> > @@ -43,3 +43,10 @@ Data: 'server' and 'client' keys with the same keys as 'query-vnc'.
> >  
> >  Description: Issued when the VNC session is made active.
> >  Data: 'server' and 'client' keys with the same keys as 'query-vnc'.
> > +
> > +7 BLOCK_IO_ERROR
> > +----------------
> > +
> > +Description: Issued when a disk I/O error occurs
> > +Data: 'device' (device name), 'action' (action to be taken),
> > +      'operation' ("read" or "write")
> 
> I think we should document what allowed values for action are and what
> their meaning is. And isn't it actually "action that has been taken"?

 Right, sometimes I don't know how to document this stuff
because this file is going to be replaced soon...