From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nck6X-00033Q-Ba
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:37:33 -0500
Received: from [199.232.76.173] (port=54725 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nck6W-000336-Sq
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:37:32 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mtosatti@redhat.com>) id 1Nck6V-0000dd-9w
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:37:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35619)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mtosatti@redhat.com>) id 1Nck6U-0000dR-DU
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:37:30 -0500
Date: Wed, 3 Feb 2010 16:36:35 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20100203183635.GA860@amt.cnet>
References: <cover.1265187223.git.jan.kiszka@siemens.com>
	<20100203165051.GA29235@amt.cnet> <4B69BA52.5050006@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B69BA52.5050006@siemens.com>
Subject: [Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and
 extended use of upstream code
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Glauber Costa <glommer@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>

On Wed, Feb 03, 2010 at 07:02:58PM +0100, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
> > On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote:
> >> This version addresses the feedback on v2, namely:
> >> - assert(<vm stopped> || <current thread == env->thread>) on low-level
> >>   load/save registers
> >> - fixed mpstate initialization
> >>
> >> Yet untested is -no-kvm-irqchip with smp due to some bug in unpatched
> >> qemu-kvm or the kernel modules. Still investigating.
> > 
> > Don't recall it ever working properly. Guess that IPI emulation with
> > signals is problematic.
> 
> OK, then it only works by chance on some boxes. Specifically, forcing
> qemu onto a single host core "solves" the issue - suspicious.
> 
> > 
> >> Pull URL is still
>
> >> 	git://git.kiszka.org/qemu-kvm.git queues/vcpu-state
> >>
> >> PS: The corresponding upstream queue is now available under
> >> queues/kvm-upstream in the same repository. Will send it out later if
> >> there are no further remarks on this series to avoid flooding the
> >> mailing lists. Early testers are nevertheless welcome.
> > 
> > Can the necessary changes for cleanups go in qemu.git first, so after
> > they're merged in qemu-kvm, we can apply the unification patches.
> > 
> > And later do the same with synchronization rework (API looks fine to
> > me).
> 
> Fine with me. Will send out my upstream queue - against uq/master or
> directly against qemu.git then?

Please send only the cleanups (up to
0160a98b9415603f583aec49b21dbd98b46ac969) for qemu.git for now, since
Avi/others might have comments on the synchronization changes.