From: Luiz Capitulino <lcapitulino@redhat.com>
To: Roy Tam <roytam@gmail.com>
Cc: aliguori@us.ibm.com, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)
Date: Thu, 4 Feb 2010 12:24:14 -0200 [thread overview]
Message-ID: <20100204122414.32e9676e@doriath> (raw)
In-Reply-To: <473191351002031830w7876c367vf534508e292c4f04@mail.gmail.com>
On Thu, 4 Feb 2010 10:30:30 +0800
Roy Tam <roytam@gmail.com> wrote:
> 2010/2/4 Roy Tam <roytam@gmail.com>:
> > 2010/2/3 Luiz Capitulino <lcapitulino@redhat.com>:
>
> OK we are fooled by the json lexer and parser. As we use %I64d to
> print 'long long' variables in Win32, but lexer and parser only deal
> with %lld but not %I64d, this patch add support for %I64d and solve
> 'info pci', 'powser_reset' and 'power_powerdown' assert failure in
> Win32.
Hm, I guess this has been suggested before... Anthony?
> P.S.: an assert(state.result != NULL) statement in
> qobject_from_jsonv() will be good for asserting failure of parsing
> JSON strings.
Yes, this change is already in a series I plan to send shortly.
Thanks a lot for tracking this down.
next prev parent reply other threads:[~2010-02-04 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 2:30 [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed) Roy Tam
2010-02-04 2:34 ` Roy Tam
2010-02-04 14:24 ` Luiz Capitulino [this message]
2010-02-04 16:59 ` Roy Tam
2010-02-08 16:21 ` Anthony Liguori
2010-02-10 19:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204122414.32e9676e@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).