From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nd2dC-0000g9-W8
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:24:31 -0500
Received: from [199.232.76.173] (port=54636 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nd2dC-0000fR-Dq
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:24:30 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nd2d9-0008An-C8
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:24:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:19477)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nd2d8-0008AL-NB
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:24:27 -0500
Date: Thu, 4 Feb 2010 12:24:14 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel]
	system_reset  command cause assert failed)
Message-ID: <20100204122414.32e9676e@doriath>
In-Reply-To: <473191351002031830w7876c367vf534508e292c4f04@mail.gmail.com>
References: <473191351002031830w7876c367vf534508e292c4f04@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Tam <roytam@gmail.com>
Cc: aliguori@us.ibm.com, qemu-devel <qemu-devel@nongnu.org>

On Thu, 4 Feb 2010 10:30:30 +0800
Roy Tam <roytam@gmail.com> wrote:

> 2010/2/4 Roy Tam <roytam@gmail.com>:
> > 2010/2/3 Luiz Capitulino <lcapitulino@redhat.com>:
> 
> OK we are fooled by the json lexer and parser. As we use %I64d to
> print 'long long' variables in Win32, but lexer and parser only deal
> with %lld but not %I64d, this patch add support for %I64d and solve
> 'info pci', 'powser_reset' and 'power_powerdown' assert failure in
> Win32.

 Hm, I guess this has been suggested before... Anthony?

> P.S.: an assert(state.result != NULL) statement in
> qobject_from_jsonv() will be good for asserting failure of parsing
> JSON strings.

 Yes, this change is already in a series I plan to send shortly.

 Thanks a lot for tracking this down.