From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nd34Z-0000rn-Q5
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:52:47 -0500
Received: from [199.232.76.173] (port=43892 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nd34Z-0000rT-1F
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:52:47 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mtosatti@redhat.com>) id 1Nd34V-0005YN-Gd
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:52:46 -0500
Received: from mx20.gnu.org ([199.232.41.8]:6455)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <mtosatti@redhat.com>) id 1Nd34U-0005Xr-HT
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 09:52:42 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mtosatti@redhat.com>) id 1Nd1KK-0000T5-Ig
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 08:00:56 -0500
Date: Thu, 4 Feb 2010 11:00:38 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20100204130038.GA15671@amt.cnet>
References: <cover.1265232578.git.jan.kiszka@siemens.com>
	<372238c800e0d57815f472502fdf78e53463bbb6.1265232579.git.jan.kiszka@siemens.com>
	<20100203234929.GA11012@amt.cnet> <4B6A15EE.4050501@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B6A15EE.4050501@web.de>
Subject: [Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state
	writing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

On Thu, Feb 04, 2010 at 01:33:50AM +0100, Jan Kiszka wrote:
> Marcelo Tosatti wrote:
> > On Wed, Feb 03, 2010 at 10:29:45PM +0100, Jan Kiszka wrote:
> >> So far we synchronized any dirty VCPU state back into the kernel before
> >> updating the guest debug state. This was a tribute to a deficit in x86
> >> kernels before 2.6.33. But as this is an arch-dependent issue, it is
> >> better handle in the x86 part of KVM and remove the writeback point for
> >> generic code.
> > 
> > Jan,
> > 
> > This patch breaks migration.
> 
> Can you elaborate what you did? I can't reproduce, and I do not see any
> conceptual issue (given that guest debugging conflicts with migration
> anyway).

kvm-autotest fails (migration only, install is ok, both Linux and Win
guests). Not sure why, perhaps the unconditional KVM_SET_GUEST_DEBUG
corrupts state somehow? 

Tested with io thread enabled.