From: Sheng Yang <sheng@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com
Subject: [Qemu-devel] Re: [PATCH] qemu-img: avoid preprocessor directives in a printf call
Date: Thu, 4 Feb 2010 23:13:45 +0800 [thread overview]
Message-ID: <201002042313.45353.sheng@linux.intel.com> (raw)
In-Reply-To: <1265290180-31243-1-git-send-email-pbonzini@redhat.com>
On Thursday 04 February 2010 21:29:40 Paolo Bonzini wrote:
> Other choices include using "(printf)", but this one is not bad in
> terms of readability.
This works well. :)
Acked-by: Sheng Yang <sheng@linux.intel.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
And there is two more...
One is:
readline.c:31:1: error: "printf" redefined
In file included from /usr/include/stdio.h:844,
from qemu-common.h:21,
from readline.h:4,
from readline.c:24:
/usr/include/bits/stdio2.h:65:1: error: this is the location of the previous
definition
make: *** [readline.o] Error 1
Of course, what you can see in readline.c is:
#define printf do_not_use_printf
I guess it's OK to remove this?
And there is last one in help() of vl.c...
After resolve these three, the build is fine now.
Paolo, could you address the other two issues as well in your patch? Thanks!
--
regards
Yang, Sheng
next prev parent reply other threads:[~2010-02-04 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 7:04 [Qemu-devel] "Enable _FORTIFY_SOURCE=2" result in building failure for qemu-img.c Sheng Yang
2010-02-04 12:09 ` [Qemu-devel] " Paolo Bonzini
2010-02-04 12:10 ` [Qemu-devel] " Jamie Lokier
2010-02-04 17:52 ` Markus Armbruster
2010-02-04 12:31 ` [Qemu-devel] " Juan Quintela
2010-02-04 13:29 ` [Qemu-devel] [PATCH] qemu-img: avoid preprocessor directives in a printf call Paolo Bonzini
2010-02-04 15:13 ` Sheng Yang [this message]
2010-02-04 15:49 ` [Qemu-devel] [PATCH 0/4] Fix printf calls embedding preprocessor directives Paolo Bonzini
2010-02-05 2:26 ` [Qemu-devel] " Sheng Yang
2010-02-05 8:30 ` Kevin Wolf
2010-02-05 8:47 ` Paolo Bonzini
2010-02-04 15:49 ` [Qemu-devel] [PATCH 1/4] qemu-img: avoid preprocessor directives in a printf call Paolo Bonzini
2010-02-04 15:49 ` [Qemu-devel] [PATCH 2/4] cope with printf macro definition in readline.c Paolo Bonzini
2010-02-04 15:49 ` [Qemu-devel] [PATCH 3/4] do not interpolate % from vl.c to qemu-options.h Paolo Bonzini
2010-02-04 15:49 ` [Qemu-devel] [PATCH 4/4] vl.c: avoid preprocessor directives in a printf call Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002042313.45353.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=aliguori@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).