From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nd3QN-0005Ki-E5
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 10:15:19 -0500
Received: from [199.232.76.173] (port=60169 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nd3QN-0005KT-04
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 10:15:19 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <sheng@linux.intel.com>) id 1Nd3QL-0008Tv-DI
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 10:15:18 -0500
Received: from mga07.intel.com ([143.182.124.22]:25425
	helo=azsmga101.ch.intel.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sheng@linux.intel.com>) id 1Nd3QK-0008TZ-Uy
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 10:15:17 -0500
From: Sheng Yang <sheng@linux.intel.com>
Date: Thu, 4 Feb 2010 23:13:45 +0800
References: <m3mxzp2ndn.fsf@neno.neno>
	<1265290180-31243-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1265290180-31243-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201002042313.45353.sheng@linux.intel.com>
Subject: [Qemu-devel] Re: [PATCH] qemu-img: avoid preprocessor directives in
	a printf call
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com

On Thursday 04 February 2010 21:29:40 Paolo Bonzini wrote:
> Other choices include using "(printf)", but this one is not bad in
> terms of readability.

This works well. :)

Acked-by: Sheng Yang <sheng@linux.intel.com>
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

And there is two more...

One is:

readline.c:31:1: error: "printf" redefined
In file included from /usr/include/stdio.h:844,
                 from qemu-common.h:21,
                 from readline.h:4,
                 from readline.c:24:
/usr/include/bits/stdio2.h:65:1: error: this is the location of the previous 
definition
make: *** [readline.o] Error 1

Of course, what you can see in readline.c is:

#define printf do_not_use_printf

I guess it's OK to remove this?

And there is last one in help() of vl.c...

After resolve these three, the build is fine now.

Paolo, could you address the other two issues as well in your patch? Thanks!

-- 
regards
Yang, Sheng