qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Isaku Yamahata <yamahata@valinux.co.jp>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH] apb_pci: fix header type of pbm pci host bridge.
Date: Mon, 8 Feb 2010 15:45:03 +0900	[thread overview]
Message-ID: <20100208064503.GE22624@valinux.co.jp> (raw)

The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
specifies pbm pci host bridge is type of bridge.
It contradicts with pbm_pci_host_init().

Blue Swirl, could you please check this patch?
To be honest I don't know about pbm pci host bridge so that
I don't know which is correct, pbm_pci_host_init() or pbm_pci_host_info.
I just took the older code.

Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/apb_pci.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/hw/apb_pci.c b/hw/apb_pci.c
index 46d5b0e..359a84f 100644
--- a/hw/apb_pci.c
+++ b/hw/apb_pci.c
@@ -471,7 +471,7 @@ static int pbm_pci_host_init(PCIDevice *d)
     d->config[0x09] = 0x00; // programming i/f
     pci_config_set_class(d->config, PCI_CLASS_BRIDGE_HOST);
     d->config[0x0D] = 0x10; // latency_timer
-    d->config[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type
+    /* header type is initialized by do_pci_register_device() */
     return 0;
 }
 
@@ -479,7 +479,6 @@ static PCIDeviceInfo pbm_pci_host_info = {
     .qdev.name = "pbm",
     .qdev.size = sizeof(PCIDevice),
     .init      = pbm_pci_host_init,
-    .header_type  = PCI_HEADER_TYPE_BRIDGE,
 };
 
 static SysBusDeviceInfo pbm_host_info = {
-- 
1.6.6.1

             reply	other threads:[~2010-02-08  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08  6:45 Isaku Yamahata [this message]
2010-02-08 10:26 ` [Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host bridge Michael S. Tsirkin
2010-02-08 10:27 ` Michael S. Tsirkin
2010-02-08 17:29 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100208064503.GE22624@valinux.co.jp \
    --to=yamahata@valinux.co.jp \
    --cc=blauwirbel@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).