From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NeS5H-0007SG-1k for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:47:19 -0500 Received: from [199.232.76.173] (port=56496 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NeS5G-0007S7-JA for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:47:18 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NeS5F-0001sq-1v for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:47:18 -0500 Received: from afflict.kos.to ([92.243.29.197]:56636) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NeS5E-0001rY-4C for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:47:16 -0500 Date: Mon, 8 Feb 2010 11:47:13 +0000 From: Riku Voipio Subject: Re: [Qemu-devel] [PATCH 4/4] target-arm: neon fix Message-ID: <20100208114713.GA19863@afflict.kos.to> References: <1265385151-11024-1-git-send-email-riku.voipio@iki.fi> <1265385151-11024-5-git-send-email-riku.voipio@iki.fi> <761ea48b1002070454j365537an16ef9a767ab8c199@mail.gmail.com> <761ea48b1002070502yaf00e06x9630b3fea7e5c106@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <761ea48b1002070502yaf00e06x9630b3fea7e5c106@mail.gmail.com> Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: Riku Voipio , qemu-devel@nongnu.org On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote: > On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues > wrote: > > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrot= e: > >> From: Juha Riihim=C3=A4ki > >> add an extra check in "two registers and a shift" to ensure element > >> size decoding logic cannot fail. > > I think there's a patch ordering problem that makes > > the comment and the change not agree :-) Sorry, apparently messed up while rebasing. =20 > BTW I don't think adding the check for size is needed > here. The encoding at that point looks like this: =20 > 3322222222221111111111 > 10987654321098765432109876543210 > 1111001_1___1______________1____ > 1111001_1__1_______________1____ > 1111001_1_1________________1____ =20 > so it will stop for size =3D=3D 0 given that bit 19 will have to > be set. Juha agrees so we'll drop this patch (or more precisely get the actual ch= ange out of the previous patch..)