From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NeVuy-0005Jc-JZ
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:52:56 -0500
Received: from [199.232.76.173] (port=40045 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NeVuy-0005JS-5d
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:52:56 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mtosatti@redhat.com>) id 1NeVuw-0003vA-0N
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:52:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44247)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mtosatti@redhat.com>) id 1NeVuv-0003tP-Fv
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 10:52:53 -0500
Date: Mon, 8 Feb 2010 13:52:16 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20100208155216.GB2887@amt.cnet>
References: <cover.1265232578.git.jan.kiszka@siemens.com>
	<372238c800e0d57815f472502fdf78e53463bbb6.1265232579.git.jan.kiszka@siemens.com>
	<20100203234929.GA11012@amt.cnet> <4B6A15EE.4050501@web.de>
	<20100204130038.GA15671@amt.cnet> <4B6AE1E6.9040805@siemens.com>
	<4B6AEAB8.3030509@siemens.com> <20100204180555.GA3861@amt.cnet>
	<4B6B179A.3080704@siemens.com> <4B6B1E24.2090505@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B6B1E24.2090505@siemens.com>
Subject: [Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state
	writing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

On Thu, Feb 04, 2010 at 08:21:08PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Marcelo Tosatti wrote:
> >> With kvm-autotest the failure is not sporadic (and the above commit
> >> applied): with KVM_SET_GUEST_DEBUG in arch_put_regs all migration 
> >> tests fail, without, all of them succeed. 
> >>
> >> So env->kvm_guest_debug has been zeroed by cpu_x86_init, which means
> >> the writeback via KVM_SET_GUEST_DEBUG does almost nothing. It does
> >> get_rflags and set_rflags in the kernel.
> > 
> > Hmm, it also copies debug regs around... BTW, where do we save/restore
> > dr0..7 between kernel and user space?
> > 
> > But that should not be a problem, both shadow as well as effective regs
> > should be properly initialized, specifically for a newly created VCPU.
> 
> Could you retry after pushing SET_GUEST_DEBUG at the end of
> kvm_arch_put_registers? Maybe it is no good idea to run get/set_rflags
> without having the sregs properly initialized.
> 
> Jan

Can't reproduce (with the original patch, KVM_SET_GUEST_DEBUG at
beginning of arch_put_regs). Different test box though. Go figure.

Anyway, as you mentioned, the workaround can be made cleaner through
set_vcpu_events.