From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NeXW5-0002FX-UW
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:35:21 -0500
Received: from [199.232.76.173] (port=43801 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NeXW5-0002FF-9i
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:35:21 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NeXW3-0001d9-I7
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:35:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36959)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NeXW3-0001cr-5Q
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:35:19 -0500
Date: Mon, 8 Feb 2010 19:32:04 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.
Message-ID: <20100208173204.GA10716@redhat.com>
References: <20100208064147.GD22624@valinux.co.jp>
	<20100208101753.GA14662@redhat.com> <4B6FF203.6010304@redhat.com>
	<20100208162753.GA28230@redhat.com> <4B7048E9.6000706@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B7048E9.6000706@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 17:27, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
>>> On 02/08/10 11:17, Michael S. Tsirkin wrote:
>>>> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>>>>> initialize header type register in pci generic code.
>>>>>
>>>>> Cc: Blue Swirl<blauwirbel@gmail.com>
>>>>> Cc: "Michael S. Tsirkin"<mst@redhat.com>
>>>>> Signed-off-by: Isaku Yamahata<yamahata@valinux.co.jp>
>>>>
>>>> No objections here, I am assuming this will be followed
>>>> by patches removing header type init from bridges?
>>>>   From qdev perspective, it is probably cleaner to make
>>>> multifunction bit a separate qdev property though, right?
>>>
>>>  From a qdev perspective it would make *alot* of sense to move a bunch of
>>> pci config stuff (including, but not limited to header type) into
>>> PCIDeviceInfo.
>>>
>>> cheers,
>>>    Gerd
>>
>> Actually - won't this make it possible to create broken configurations
>> by tweaking properties from command-line?
>
> Not as property, as struct element in PCIDeviceInfo.  i.e.
>
> static PCIDeviceInfo e1000_info = {
>     [ stuff which is here right now ]
>     .vendor_id = PCI_VENDOR_ID_INTEL,
>     .device_id = E1000_DEVID,
>     .class     = PCI_CLASS_NETWORK_ETHERNET,
>     [ probably more stuff which makes sense ]
> }
>
> Then setup this in generic pci code instead of having each driver doing  
> a bunch of pci_config_set_*() calls.
>
> cheers,
>   Gerd

We still end up with class, vendor etc duplicated in 2 places.  Why do
we want stuff like vendor id in PCIDeviceInfo at all?  Why can't
everyone just use pci_config_set/get calls?

-- 
MST