[Qemu-devel] iothread + smp 2 + alt-f4 = lock-up

[Qemu-devel] iothread + smp 2 + alt-f4 = lock-up

[Jan Kiszka]

Just a note, maybe someone finds the time to look at this:

Sending ALT-F4 to the SDL window of qemu (stable-0.12 and master) when
it was configured with --enable-io-thread and runs -smp 2 or more causes
a lock-up of the qemu process.

[I currently trigger way too many bugs...]

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

[Qemu-devel] [PATCH] iothread: fix vcpu stop with smp tcg

[Marcelo Tosatti]

Round robin vcpus in tcg_cpu_next even if the vm stopped. This
allows all cpus to enter stopped state.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/vl.c b/vl.c
index 880bcd5..f61e362 100644
--- a/vl.c
+++ b/vl.c
@@ -3855,14 +3855,15 @@ static void tcg_cpu_exec(void)
     for (; next_cpu != NULL; next_cpu = next_cpu->next_cpu) {
         CPUState *env = cur_cpu = next_cpu;
 
-        if (!vm_running)
-            break;
         if (timer_alarm_pending) {
             timer_alarm_pending = 0;
             break;
         }
         if (cpu_can_run(env))
             ret = qemu_cpu_exec(env);
+        else if (env->stop)
+            break;
+
         if (ret == EXCP_DEBUG) {
             gdb_set_stop_cpu(env);
             debug_requested = 1;

Re: [Qemu-devel] [PATCH] iothread: fix vcpu stop with smp tcg

[Anthony Liguori]

On 02/09/2010 08:49 AM, Marcelo Tosatti wrote:
> Round robin vcpus in tcg_cpu_next even if the vm stopped. This
> allows all cpus to enter stopped state.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> diff --git a/vl.c b/vl.c
> index 880bcd5..f61e362 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3855,14 +3855,15 @@ static void tcg_cpu_exec(void)
>       for (; next_cpu != NULL; next_cpu = next_cpu->next_cpu) {
>           CPUState *env = cur_cpu = next_cpu;
>
> -        if (!vm_running)
> -            break;
>           if (timer_alarm_pending) {
>               timer_alarm_pending = 0;
>               break;
>           }
>           if (cpu_can_run(env))
>               ret = qemu_cpu_exec(env);
> +        else if (env->stop)
> +            break;
> +
>           if (ret == EXCP_DEBUG) {
>               gdb_set_stop_cpu(env);
>               debug_requested = 1;
>
>
>
>