* [Qemu-devel] [PATCH] fix inet_parse typo
@ 2010-02-09 17:31 Marcelo Tosatti
2010-02-10 19:31 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2010-02-09 17:31 UTC (permalink / raw)
To: qemu-devel; +Cc: xming
qemu_opt_set wants on/off, not yes/no.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 8850516..a88b2a7 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
__FUNCTION__, str);
return -1;
}
- qemu_opt_set(opts, "ipv6", "yes");
+ qemu_opt_set(opts, "ipv6", "on");
} else if (qemu_isdigit(str[0])) {
/* IPv4 addr */
if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
@@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
__FUNCTION__, str);
return -1;
}
- qemu_opt_set(opts, "ipv4", "yes");
+ qemu_opt_set(opts, "ipv4", "on");
} else {
/* hostname */
if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
@@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
if (h)
qemu_opt_set(opts, "to", h+4);
if (strstr(optstr, ",ipv4"))
- qemu_opt_set(opts, "ipv4", "yes");
+ qemu_opt_set(opts, "ipv4", "on");
if (strstr(optstr, ",ipv6"))
- qemu_opt_set(opts, "ipv6", "yes");
+ qemu_opt_set(opts, "ipv6", "on");
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] fix inet_parse typo
2010-02-09 17:31 [Qemu-devel] [PATCH] fix inet_parse typo Marcelo Tosatti
@ 2010-02-10 19:31 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-02-10 19:31 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: xming, qemu-devel
On 02/09/2010 11:31 AM, Marcelo Tosatti wrote:
> qemu_opt_set wants on/off, not yes/no.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index 8850516..a88b2a7 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
> __FUNCTION__, str);
> return -1;
> }
> - qemu_opt_set(opts, "ipv6", "yes");
> + qemu_opt_set(opts, "ipv6", "on");
> } else if (qemu_isdigit(str[0])) {
> /* IPv4 addr */
> if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
> @@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
> __FUNCTION__, str);
> return -1;
> }
> - qemu_opt_set(opts, "ipv4", "yes");
> + qemu_opt_set(opts, "ipv4", "on");
> } else {
> /* hostname */
> if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
> @@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
> if (h)
> qemu_opt_set(opts, "to", h+4);
> if (strstr(optstr, ",ipv4"))
> - qemu_opt_set(opts, "ipv4", "yes");
> + qemu_opt_set(opts, "ipv4", "on");
> if (strstr(optstr, ",ipv6"))
> - qemu_opt_set(opts, "ipv6", "yes");
> + qemu_opt_set(opts, "ipv6", "on");
> return 0;
> }
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-10 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 17:31 [Qemu-devel] [PATCH] fix inet_parse typo Marcelo Tosatti
2010-02-10 19:31 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).