From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "blauwirbel@gmail.com" <blauwirbel@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aurelien@aurel32.net" <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: [PATCH 00/10] PPC NewWorld fixery v4
Date: Tue, 9 Feb 2010 23:31:02 +0200 [thread overview]
Message-ID: <20100209213102.GA12492@redhat.com> (raw)
In-Reply-To: <9CE94B25-26C8-49ED-8355-FFAA62698CAE@suse.de>
On Tue, Feb 09, 2010 at 10:24:22PM +0100, Alexander Graf wrote:
>
> On 09.02.2010, at 21:39, Michael S. Tsirkin wrote:
>
> > On Tue, Feb 09, 2010 at 09:37:18PM +0100, aurelien@aurel32.net wrote:
> >> On Tue, Feb 09, 2010 at 10:30:19PM +0200, Michael S. Tsirkin wrote:
> >>> On Tue, Feb 09, 2010 at 07:26:45PM +0100, Alexander Graf wrote:
> >>>>
> >>>> Am 09.02.2010 um 18:01 schrieb "Michael S. Tsirkin" <mst@redhat.com>:
> >>>>
> >>>>> On Tue, Feb 09, 2010 at 05:37:00PM +0100, Alexander Graf wrote:
> >>>>>> I'm trying to get the PPC64 system emulation target working finally.
> >>>>>> While doing so, I ran into several issues, most related to PCI this
> >>>>>> time.
> >>>>>>
> >>>>>> This patchset fixes all the PCI config space access and PCI interrupt
> >>>>>> mapping issues I've found on PPC64. Using this and a patched OpenBIOS
> >>>>>> version, I can successfully access IDE devices and was booting a
> >>>>>> guest
> >>>>>> into the shell from IDE using serial console.
> >>>>>
> >>>>> Trying to apply these I run into:
> >>>>>
> >>>>> Applying: PPC: Make interrupts work
> >>>>> /scm/qemu/.git/rebase-apply/patch:27: trailing whitespace.
> >>>>>
> >>>>> /scm/qemu/.git/rebase-apply/patch:29: trailing whitespace.
> >>>>>
> >>>>> warning: 2 lines add whitespace errors.
> >>>>> Applying: PPC: tell the guest about the time base frequency
> >>>>> /scm/qemu/.git/rebase-apply/patch:83: new blank line at EOF.
> >>>>> +
> >>>>> warning: 1 line adds whitespace errors.
> >>>>>
> >>>>> Could you address these please?
> >>>>
> >>>> git-am should take care of them, no?
> >>>>
> >>>> Alex
> >>>
> >>> It doesn't fix them, just complains.
> >>>
> >>
> >> --whitespace=strip
> >
> > Ah, ok. Anyway I prefer patch author to fix these up in source, rather
> > then rely on tools.
>
> What do we have tools for then? :)
>
> Alex
OK, I did that for now.
Please fix trivial stuff before post in the future.
--
MST
next prev parent reply other threads:[~2010-02-09 21:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 16:37 [Qemu-devel] [PATCH 00/10] PPC NewWorld fixery v4 Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 01/10] PPC: Uninorth config space accessor Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 02/10] PPC: Use Mac99_U3 type on ppc64 Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 03/10] PPC: Include dump of lspci -nn on real G5 Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 04/10] PPC: Make interrupts work Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 05/10] PPC: tell the guest about the time base frequency Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 06/10] PPC: Use macio IDE controller for Newworld Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 07/10] PPC: Get rid of segfaults in DBDMA emulation Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 08/10] PPC: Add USB per default on U3 Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 09/10] PPC: Fix large pages Alexander Graf
2010-02-09 16:37 ` [Qemu-devel] [PATCH 10/10] PPC: Add timer when running KVM Alexander Graf
2010-02-09 17:01 ` [Qemu-devel] Re: [PATCH 00/10] PPC NewWorld fixery v4 Michael S. Tsirkin
2010-02-09 18:26 ` Alexander Graf
2010-02-09 20:30 ` Michael S. Tsirkin
2010-02-09 20:37 ` aurelien
2010-02-09 20:39 ` Michael S. Tsirkin
2010-02-09 21:24 ` Alexander Graf
2010-02-09 21:31 ` Michael S. Tsirkin [this message]
2010-02-09 21:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209213102.GA12492@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).