From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nexj1-0007Bk-5G for qemu-devel@nongnu.org; Tue, 09 Feb 2010 16:34:27 -0500 Received: from [199.232.76.173] (port=54798 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nexj0-0007Bc-P9 for qemu-devel@nongnu.org; Tue, 09 Feb 2010 16:34:26 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nexiz-0001dH-57 for qemu-devel@nongnu.org; Tue, 09 Feb 2010 16:34:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26733) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nexiy-0001cn-OE for qemu-devel@nongnu.org; Tue, 09 Feb 2010 16:34:25 -0500 Date: Tue, 9 Feb 2010 23:31:02 +0200 From: "Michael S. Tsirkin" Message-ID: <20100209213102.GA12492@redhat.com> References: <1265733430-9656-1-git-send-email-agraf@suse.de> <20100209170134.GA4999@redhat.com> <18955DE3-36AD-44FD-B7E8-23EF94BD172A@suse.de> <20100209203019.GA12100@redhat.com> <20100209203718.GQ22947@hall.aurel32.net> <20100209203919.GA12251@redhat.com> <9CE94B25-26C8-49ED-8355-FFAA62698CAE@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9CE94B25-26C8-49ED-8355-FFAA62698CAE@suse.de> Subject: [Qemu-devel] Re: [PATCH 00/10] PPC NewWorld fixery v4 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "blauwirbel@gmail.com" , "qemu-devel@nongnu.org" , "aurelien@aurel32.net" On Tue, Feb 09, 2010 at 10:24:22PM +0100, Alexander Graf wrote: > > On 09.02.2010, at 21:39, Michael S. Tsirkin wrote: > > > On Tue, Feb 09, 2010 at 09:37:18PM +0100, aurelien@aurel32.net wrote: > >> On Tue, Feb 09, 2010 at 10:30:19PM +0200, Michael S. Tsirkin wrote: > >>> On Tue, Feb 09, 2010 at 07:26:45PM +0100, Alexander Graf wrote: > >>>> > >>>> Am 09.02.2010 um 18:01 schrieb "Michael S. Tsirkin" : > >>>> > >>>>> On Tue, Feb 09, 2010 at 05:37:00PM +0100, Alexander Graf wrote: > >>>>>> I'm trying to get the PPC64 system emulation target working finally. > >>>>>> While doing so, I ran into several issues, most related to PCI this > >>>>>> time. > >>>>>> > >>>>>> This patchset fixes all the PCI config space access and PCI interrupt > >>>>>> mapping issues I've found on PPC64. Using this and a patched OpenBIOS > >>>>>> version, I can successfully access IDE devices and was booting a > >>>>>> guest > >>>>>> into the shell from IDE using serial console. > >>>>> > >>>>> Trying to apply these I run into: > >>>>> > >>>>> Applying: PPC: Make interrupts work > >>>>> /scm/qemu/.git/rebase-apply/patch:27: trailing whitespace. > >>>>> > >>>>> /scm/qemu/.git/rebase-apply/patch:29: trailing whitespace. > >>>>> > >>>>> warning: 2 lines add whitespace errors. > >>>>> Applying: PPC: tell the guest about the time base frequency > >>>>> /scm/qemu/.git/rebase-apply/patch:83: new blank line at EOF. > >>>>> + > >>>>> warning: 1 line adds whitespace errors. > >>>>> > >>>>> Could you address these please? > >>>> > >>>> git-am should take care of them, no? > >>>> > >>>> Alex > >>> > >>> It doesn't fix them, just complains. > >>> > >> > >> --whitespace=strip > > > > Ah, ok. Anyway I prefer patch author to fix these up in source, rather > > then rely on tools. > > What do we have tools for then? :) > > Alex OK, I did that for now. Please fix trivial stuff before post in the future. -- MST