From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nft7n-0006Pv-KZ
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 05:51:51 -0500
Received: from [199.232.76.173] (port=39998 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nft7m-0006PI-IR
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 05:51:50 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1Nft7l-0004NJ-8D
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 05:51:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34330)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Nft7k-0004NC-PV
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 05:51:49 -0500
Date: Fri, 12 Feb 2010 12:47:54 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100212104754.GD21947@redhat.com>
References: <20100211172236.GA20357@redhat.com>
	<201002122017.55536.rusty@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201002122017.55536.rusty@rustcorp.com.au>
Subject: [Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: markmc@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org

On Fri, Feb 12, 2010 at 08:17:55PM +1030, Rusty Russell wrote:
> On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> > This documents MSI-X support in virtio.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Wow, great!
> 
> I reworked one paragraph for better grammar.  Mainly adding "the":
> 
> (pseudo-patch):
>     Devices report such failures by returning +the+ NO_VECTOR value
>     when the relevant Vector field is read. After mapping an event to vector,
>     +the+ driver must verify success by reading the Vector field value: on
>     success, +the+ previously written value is returned-;-+, and+ on failure,
>     NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
>     driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.

Looks good, thanks for the corrections!

> I really liked the conversational style: standards can be intimidating and
> unfriendly documents if they concentrate too much on partitioning all
> information into precise sections.
> 
> That makes it 0.8.6.  I will re-read the entire document for consistency
> before releasing 0.9.
> 
> Thanks!
> Rusty.