From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] pci: introduce get_info_quirk callback.
Date: Fri, 12 Feb 2010 22:34:34 +0900 [thread overview]
Message-ID: <20100212133434.GI11930@valinux.co.jp> (raw)
In-Reply-To: <20100212125457.GH21947@redhat.com>
On Fri, Feb 12, 2010 at 02:54:59PM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 12, 2010 at 11:31:34AM +0900, Isaku Yamahata wrote:
> > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5
> > by introducing device specific get_info_quirk callback.
> > It wrongly assumes that pci host bridge class device has
> > header type of pci-pci bridge. But this isn't always true.
> > In fact i440fx pci host bridge has header type of normal device,
> > hence it breaks i440fx and other pci host bridges.
> > The right fix is that header type should be checked, instead of device class.
> >
> > The change set's purpose is to show PBM pci host bridge
> > info which doesn't conform to PCI specification.
>
> So, PBM has header type PCI_HEADER_TYPE_NORMAL
> but all config space is in bridge format?
Some of registers is in bridge format.
To be honest, I don't know whether all or some.
Blue seems to want bus numbers registers at least.
http://lists.gnu.org/archive/html/qemu-devel/2010-02/msg00519.html
--
yamahata
next prev parent reply other threads:[~2010-02-12 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 2:31 [Qemu-devel] [PATCH] pci: introduce get_info_quirk callback Isaku Yamahata
2010-02-12 12:54 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-12 13:34 ` Isaku Yamahata [this message]
2010-02-12 20:10 ` Blue Swirl
2010-02-13 8:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212133434.GI11930@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).