From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh0pB-0000RW-Sq for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:17:18 -0500 Received: from [199.232.76.173] (port=55923 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh0p8-0000P3-NR for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:17:14 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nh0k5-0008GX-Il for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:12:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64331) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nh0k3-0008Fw-BJ for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:12:00 -0500 Date: Mon, 15 Feb 2010 15:08:33 +0200 From: "Michael S. Tsirkin" Message-ID: <20100215130833.GA3231@redhat.com> References: <201002110520.07620.rob@landley.net> <201002150510.22819.rob@landley.net> <8DF180F8-A6F3-4306-9B02-C6870156ADB1@suse.de> <201002150658.34614.rob@landley.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201002150658.34614.rob@landley.net> Subject: [Qemu-devel] Re: qemu-ppc can't run static uClibc binaries. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rob Landley Cc: Alexander Graf , qemu-devel@nongnu.org On Mon, Feb 15, 2010 at 06:58:33AM -0600, Rob Landley wrote: > On Monday 15 February 2010 05:19:24 Alexander Graf wrote: > > On 15.02.2010, at 12:10, Rob Landley wrote: > > > On Sunday 14 February 2010 08:41:00 Alexander Graf wrote: > > >> So the only case I can imagine that this breaks anything is that > > >> uClibc requires register state to be 0. > > > > > > Yes, r3 (which is the exit code from the "exec" syscall, and thus 0 if it > > > worked). In the BSD layout, it's argc (which can never be 0). > > > > > > http://lists.gnu.org/archive/html/qemu-devel/2007-03/msg00720.html > > > > So what you really want is something like > > > > #ifdef CONFIG_LINUX_USER > > /* exec return value is always 0 */ > > env->gpr[3] = 0; > > #endif > > > > just after the #endif in your patch. If you had inlined your patch I > > could've commented it there. > > Unfortunately kmail plays fast and loose with whitespace when I inline stuff. > (Not always, but I can't tell by inspection when it's decided it was hungry > for tabs or wanted to throw in that horrible UTF8 escaped whitespace.) See Documentation/email-clients.txt under linux source tree.