From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh0uV-00021Q-Bb for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:22:47 -0500 Received: from [199.232.76.173] (port=49405 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh0uU-00020t-IC for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:22:46 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nh0uT-0000d6-G0 for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:22:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39564) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nh0uT-0000ci-4F for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:22:45 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1FDMfvf032629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Feb 2010 08:22:42 -0500 Date: Mon, 15 Feb 2010 18:51:31 +0530 From: Amit Shah Message-ID: <20100215132131.GB16668@amit-x200.redhat.com> References: <20100212134214.GA4214@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100212134214.GA4214@redhat.com> Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, kraxel@redhat.com On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > serial devices declare MULTIPORT feature. > To allow 0.12 compatibility, we should clear this when > max_nr_ports is 1. > > Signed-off-by: Michael S. Tsirkin Acked-by: Amit Shah A couple more patches are needed to introduce a 0.12 machine type and default to 1 max_nr_ports for machine types < 0.13, which I'll be sending shortly. I'll also make this patch 3/3 in that series, just for completenes.. Amit