qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev
Date: Mon, 15 Feb 2010 16:07:28 +0200	[thread overview]
Message-ID: <20100215140728.GB3231@redhat.com> (raw)
In-Reply-To: <20100215132131.GB16668@amit-x200.redhat.com>

On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote:
> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> > serial devices declare MULTIPORT feature.
> > To allow 0.12 compatibility, we should clear this when
> > max_nr_ports is 1.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Acked-by: Amit Shah <amit.shah@redhat.com>
> 
> A couple more patches are needed to introduce a 0.12 machine type and
> default to 1 max_nr_ports for machine types < 0.13, which I'll be
> sending shortly.

Note that we also need to fill in virtio feature bits for the rest of
devices, per machine type.  Care to deal with it?

> I'll also make this patch 3/3 in that series, just for completenes..
> 
> 		Amit
> 

  reply	other threads:[~2010-02-15 14:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 13:42 [Qemu-devel] [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev Michael S. Tsirkin
2010-02-12 14:23 ` [Qemu-devel] " Amit Shah
2010-02-15  9:03   ` Gerd Hoffmann
2010-02-15  9:24     ` Amit Shah
2010-02-15 10:21       ` Michael S. Tsirkin
2010-02-15 12:24       ` Gerd Hoffmann
2010-02-15 13:21 ` Amit Shah
2010-02-15 14:07   ` Michael S. Tsirkin [this message]
2010-02-15 15:36     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100215140728.GB3231@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).