From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nh1f1-0001y1-AV
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:10:51 -0500
Received: from [199.232.76.173] (port=58991 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nh1f0-0001xt-UO
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:10:50 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1Nh1f0-0003e1-3F
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:10:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30923)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Nh1ez-0003dx-Nl
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:10:49 -0500
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1FEAjlS002325
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 15 Feb 2010 09:10:45 -0500
Date: Mon, 15 Feb 2010 16:07:28 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100215140728.GB3231@redhat.com>
References: <20100212134214.GA4214@redhat.com>
	<20100215132131.GB16668@amit-x200.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100215132131.GB16668@amit-x200.redhat.com>
Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1
	port dev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote:
> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
> > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
> > serial devices declare MULTIPORT feature.
> > To allow 0.12 compatibility, we should clear this when
> > max_nr_ports is 1.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Acked-by: Amit Shah <amit.shah@redhat.com>
> 
> A couple more patches are needed to introduce a 0.12 machine type and
> default to 1 max_nr_ports for machine types < 0.13, which I'll be
> sending shortly.

Note that we also need to fill in virtio feature bits for the rest of
devices, per machine type.  Care to deal with it?

> I'll also make this patch 3/3 in that series, just for completenes..
> 
> 		Amit
>