From: Amit Shah <amit.shah@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/3] pc: Add backward compatibility options for virtio-serial
Date: Mon, 15 Feb 2010 20:47:30 +0530 [thread overview]
Message-ID: <20100215151730.GB19201@amit-x200.redhat.com> (raw)
In-Reply-To: <4B795BF2.2000107@redhat.com>
On (Mon) Feb 15 2010 [15:36:34], Gerd Hoffmann wrote:
>> @@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = {
>> static void pc_machine_init(void)
>> {
>> qemu_register_machine(&pc_machine);
>> + qemu_register_machine(&pc_machine_v0_12);
>> qemu_register_machine(&pc_machine_v0_11);
>> qemu_register_machine(&pc_machine_v0_10);
>> qemu_register_machine(&isapc_machine);
>
> This chunk should have been in patch 1/3.
> Otherwise the whole series looks fine to me.
Yep, missed that. Fixed in v2.
Amit
prev parent reply other threads:[~2010-02-15 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 13:31 [Qemu-devel] [PATCH 1/3] pc: Bump up pc version to 0.13 and add a 0.12 compat version Amit Shah
2010-02-15 13:31 ` [Qemu-devel] [PATCH 2/3] pc: Add backward compatibility options for virtio-serial Amit Shah
2010-02-15 13:31 ` [Qemu-devel] [PATCH 3/3] virtio-serial: don't set MULTIPORT for 1 port dev Amit Shah
2010-02-15 14:36 ` [Qemu-devel] Re: [PATCH 2/3] pc: Add backward compatibility options for virtio-serial Gerd Hoffmann
2010-02-15 15:17 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215151730.GB19201@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).