From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh31I-0003cI-8C for qemu-devel@nongnu.org; Mon, 15 Feb 2010 10:37:56 -0500 Received: from [199.232.76.173] (port=53617 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh31H-0003bk-NU for qemu-devel@nongnu.org; Mon, 15 Feb 2010 10:37:55 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nh31G-0001AE-DP for qemu-devel@nongnu.org; Mon, 15 Feb 2010 10:37:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18335) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nh31G-0001A8-2I for qemu-devel@nongnu.org; Mon, 15 Feb 2010 10:37:54 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1FFbq34020216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Feb 2010 10:37:53 -0500 Date: Mon, 15 Feb 2010 21:06:42 +0530 From: Amit Shah Message-ID: <20100215153642.GC19201@amit-x200.redhat.com> References: <20100212134214.GA4214@redhat.com> <20100215132131.GB16668@amit-x200.redhat.com> <20100215140728.GB3231@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100215140728.GB3231@redhat.com> Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, kraxel@redhat.com On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote: > On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote: > > On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > > > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > > > serial devices declare MULTIPORT feature. > > > To allow 0.12 compatibility, we should clear this when > > > max_nr_ports is 1. > > > > > > Signed-off-by: Michael S. Tsirkin > > > > Acked-by: Amit Shah > > > > A couple more patches are needed to introduce a 0.12 machine type and > > default to 1 max_nr_ports for machine types < 0.13, which I'll be > > sending shortly. > > Note that we also need to fill in virtio feature bits for the rest of > devices, per machine type. Care to deal with it? Yes, that has to be done (and at least for s390 and ppc for virtio-serial). I've not yet seen how they work, but they should be similar to pc (if at all they have similar versioning support). Amit