From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhNtd-0007l0-Jx for qemu-devel@nongnu.org; Tue, 16 Feb 2010 08:55:25 -0500 Received: from [199.232.76.173] (port=44393 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhNtc-0007kr-TF for qemu-devel@nongnu.org; Tue, 16 Feb 2010 08:55:24 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NhNta-00043F-R0 for qemu-devel@nongnu.org; Tue, 16 Feb 2010 08:55:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1351) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NhNta-00042a-BD for qemu-devel@nongnu.org; Tue, 16 Feb 2010 08:55:22 -0500 Date: Tue, 16 Feb 2010 13:55:06 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command Message-ID: <20100216135506.GA1401@redhat.com> References: <1266008156.3474.18.camel@aglitke> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1266008156.3474.18.camel@aglitke> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Litke Cc: qemu-devel@nongnu.org On Fri, Feb 12, 2010 at 02:55:56PM -0600, Adam Litke wrote: > Arghh... Adding missing S-O-B > > Hi Anthony. I wonder if there was a problem when importing my async > command handler patchset. Since the 'balloon' command completes > immediately, it must call the completion callback before returning. > That call was missing but is added by the patch below. > > Signed-off-by: Adam Litke > > diff --git a/monitor.c b/monitor.c > index ae125b8..f94794d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params, > return -1; > } > > + cb(opaque, NULL); > return 0; > } > > -- Can we get this patch applied to GIT - without it, QEMU just hangs under libvirt immediately, since we nearly always issue a balloon command at start Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|