From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NiRbZ-00045w-PY
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 07:05:09 -0500
Received: from [199.232.76.173] (port=36310 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NiRbX-000452-5e
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 07:05:07 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1NiRbV-0004Up-Jp
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 07:05:06 -0500
Received: from mx20.gnu.org ([199.232.41.8]:35691)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <lcapitulino@redhat.com>)
	id 1NiRbV-0004Uj-BF
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 07:05:05 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NiRbU-0001SM-LJ
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 07:05:04 -0500
Date: Fri, 19 Feb 2010 10:04:50 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] QMP: Spec: Private Extensions support
Message-ID: <20100219100450.67f64cfa@redhat.com>
In-Reply-To: <4B7DB6FC.7040900@codemonkey.ws>
References: <20100218182458.07c3be6c@redhat.com>
	<4B7DB6FC.7040900@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Thu, 18 Feb 2010 15:54:04 -0600
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 02/18/2010 02:24 PM, Luiz Capitulino wrote:
> > Vendors might want to add their own extensions to QMP, as JSON itself
> > (and several other protocols) allow this someway, I think QMP should
> > allow too.
> >
> > We just have to choose a naming convention that is guaranteed not to
> > clash with any future new commands, arguments, parameters and event
> > names.
> >
> > Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> > ---
> >   QMP/qmp-spec.txt |   23 +++++++++++++++++++++++
> >   1 files changed, 23 insertions(+), 0 deletions(-)
> >
> > diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
> > index f3c0327..bc92c7e 100644
> > --- a/QMP/qmp-spec.txt
> > +++ b/QMP/qmp-spec.txt
> > @@ -215,3 +215,26 @@ Additionally, Clients must not assume any particular:
> >   - Order of json-object members or json-array elements
> >   - Amount of errors generated by a command, that is, new errors can be added
> >     to any existing command in newer versions of the Server
> > +
> > +6 Private Extensions
> > +--------------------
> > +
> > +QMP provides a special naming convention to allow the creation of independent
> > +namespaces, which allows vendors to introduce private extensions to the
> > +protocol. It is guaranteed that no future QMP version will expose any name
> > +that follows this convention.
> > +
> > +Private extensions must be in the following format:
> > +
> > +v_NAMESPACE__NAME
> > +
> > + Where,
> > +
> > +- NAME is any argument, command, event or parameter name
> > +- NAMESPACE is the namespace that NAME belongs to
> > +
> > +For example, the following command:
> > +
> > +v_ABC__insert
> > +
> > +Is called 'insert' and is part of the 'ABC' namespace.
> >    
> 
> We need a bit more than just this.  Here's my suggestion:

 I like it very much, feel free to apply.