From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NixUk-0004JM-Qa for qemu-devel@nongnu.org; Sat, 20 Feb 2010 17:08:14 -0500 Received: from [199.232.76.173] (port=42516 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NixUk-0004J6-Eq for qemu-devel@nongnu.org; Sat, 20 Feb 2010 17:08:14 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NixUi-0008Bp-Sd for qemu-devel@nongnu.org; Sat, 20 Feb 2010 17:08:14 -0500 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:63855) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NixUh-0008Av-Md for qemu-devel@nongnu.org; Sat, 20 Feb 2010 17:08:12 -0500 Date: Sat, 20 Feb 2010 22:08:05 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH 0/3] Get tcg-hppa working Message-ID: <20100220220805.GA31112@miranda.arrow> References: <20100220210754.GA31010@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: Stuart Brady , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc , qemu-devel@nongnu.org On Sun, Feb 21, 2010 at 12:54:46AM +0300, malc wrote: > On Sat, 20 Feb 2010, Stuart Brady wrote: > > > The qemu_ld / qemu_st cleanup strikes me as something that would be > > appropriate for some other TCG targets too, once this has been applied. > > Care to point out what this cleanup is, my HPPA-fu is around zero. The 'split out TLB reads from qemu_ld and qemu_st' part of patch 3, which adds a new tcg_out_tlb_read() function. That code is duplicated in tcg_out_qemu_ld() and tcg_out_qemu_st() for all archs except PPC64. It just makes the code that little bit more readable. Cheers, -- Stuart Brady