From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NjMF1-0000yy-Kf
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:33:39 -0500
Received: from [199.232.76.173] (port=51096 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NjMF1-0000yc-7a
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:33:39 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <davem@davemloft.net>) id 1NjMEz-0002qv-Hp
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:33:39 -0500
Received: from 74-93-104-97-washington.hfc.comcastbusiness.net
	([74.93.104.97]:57882 helo=sunset.davemloft.net)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <davem@davemloft.net>) id 1NjMEz-0002qm-7D
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:33:37 -0500
Date: Sun, 21 Feb 2010 15:57:19 -0800 (PST)
Message-Id: <20100221.155719.226789440.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
In-Reply-To: <201002211025.11588.rob@landley.net>
References: <f43fc5581002201359x50aff2b1ofc4f816762bda597@mail.gmail.com>
	<201002201712.23628.rob@landley.net>
	<201002211025.11588.rob@landley.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: rob@landley.net
Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, blauwirbel@gmail.com, pbonzini@redhat.com, sam@ravnborg.org, atar4qemu@googlemail.com

From: Rob Landley <rob@landley.net>
Date: Sun, 21 Feb 2010 10:25:09 -0600

> 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit
> commit 085219f79cad89291699bd2bfb21c9fdabafe65f
> Author: Sam Ravnborg <sam@ravnborg.org>
> Date:   Fri Jan 2 18:47:34 2009 -0800
> 
>     sparc32: use proper types in struct stat
>     
>     Like sparc64 use proper types in struct stat
>     
>     Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> This commit breaks stat and makes sparc32 essentially unusable.  It changes 
> the size of the various types in stat.h, and means that if you "mount -t tmpfs 
> /tmp /tmp" and then try to ls /tmp, ls dies with a memory allocation error.
> 
> I've confirmed that reverting it fixes the problem.

Thanks for tracking this down Rob, I'll work on a fix and
push it around.