qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rob@landley.net
Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
	blauwirbel@gmail.com, pbonzini@redhat.com, sam@ravnborg.org,
	atar4qemu@googlemail.com
Subject: [Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28.
Date: Sun, 21 Feb 2010 18:06:58 -0800 (PST)	[thread overview]
Message-ID: <20100221.180658.226784107.davem@davemloft.net> (raw)
In-Reply-To: <201002211025.11588.rob@landley.net>


Here's the fix I'll use, thanks for the report Rob:

sparc32: Fix struct stat uid/gid types.

Commit 085219f79cad89291699bd2bfb21c9fdabafe65f
("sparc32: use proper types in struct stat")

Accidently changed the struct stat uid/gid members
to uid_t and gid_t, but those get set to
__kernel_uid32_t and __kernel_gid32_t respectively.
Those are of type 'int' but the structure is meant
to have 'short'.  So use uid16_t and gid16_t to
correct this.

Reported-by: Rob Landley <rob@landley.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/include/asm/stat.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sparc/include/asm/stat.h b/arch/sparc/include/asm/stat.h
index 55db5ec..39327d6 100644
--- a/arch/sparc/include/asm/stat.h
+++ b/arch/sparc/include/asm/stat.h
@@ -53,8 +53,8 @@ struct stat {
 	ino_t		st_ino;
 	mode_t		st_mode;
 	short		st_nlink;
-	uid_t		st_uid;
-	gid_t		st_gid;
+	uid16_t		st_uid;
+	gid16_t		st_gid;
 	unsigned short	st_rdev;
 	off_t		st_size;
 	time_t		st_atime;
-- 
1.6.6.1

  parent reply	other threads:[~2010-02-22  2:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 11:20 [Qemu-devel] qemu-ppc can't run static uClibc binaries Rob Landley
2010-02-11 12:32 ` Alexander Graf
2010-02-14  8:36   ` Rob Landley
2010-02-14 14:41     ` Alexander Graf
2010-02-15 11:10       ` Rob Landley
2010-02-15 11:19         ` Alexander Graf
2010-02-15 12:58           ` Rob Landley
2010-02-15 13:01             ` Alexander Graf
2010-02-16 18:31               ` Rob Landley
2010-02-16 18:36                 ` Alexander Graf
2010-02-16 19:14                   ` Rob Landley
2010-02-15 13:08             ` [Qemu-devel] " Michael S. Tsirkin
2010-02-16  0:52               ` Rob Landley
2010-02-16  9:31                 ` Alexander Graf
2010-02-16 18:14                   ` Rob Landley
2010-02-17  9:24                     ` Artyom Tarasenko
2010-02-17 15:45                       ` Paolo Bonzini
2010-02-17 18:55                         ` Rob Landley
2010-02-17 20:46                           ` Blue Swirl
2010-02-18 11:38                             ` Artyom Tarasenko
2010-02-18 13:17                               ` Rob Landley
2010-02-18 14:10                                 ` Artyom Tarasenko
2010-02-18 13:05                             ` Rob Landley
2010-02-18 11:21                           ` Artyom Tarasenko
2010-02-18 13:14                             ` Rob Landley
2010-02-18 14:19                               ` Artyom Tarasenko
2010-02-20 17:17                             ` [Qemu-devel] Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.) Rob Landley
2010-02-20 17:34                               ` [Qemu-devel] " Blue Swirl
2010-02-20 18:38                                 ` Rob Landley
2010-02-20 21:59                                   ` Blue Swirl
2010-02-20 23:12                                     ` Rob Landley
2010-02-21 16:25                                       ` [Qemu-devel] Commit 085219f79cad broke Sparc-32 back in 2.6.28 Rob Landley
2010-02-21 23:57                                         ` [Qemu-devel] " David Miller
2010-02-22  0:28                                           ` Bartlomiej Zolnierkiewicz
2010-02-22  2:03                                             ` Rob Landley
2010-02-22  2:06                                         ` David Miller [this message]
2010-02-20 21:59                                   ` [Qemu-devel] Re: Fun with sparc (was Re: qemu-ppc can't run static uClibc binaries.) Artyom Tarasenko
2010-02-20 21:39                                 ` Artyom Tarasenko
2010-02-20 22:03                                   ` Blue Swirl
2010-02-17 16:36                       ` [Qemu-devel] Re: qemu-ppc can't run static uClibc binaries Rob Landley
2010-02-16  8:21           ` [Qemu-devel] " Stuart Brady
2010-02-28 21:05             ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100221.180658.226784107.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=atar4qemu@googlemail.com \
    --cc=blauwirbel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rob@landley.net \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).