* [Qemu-devel] [PATCH] fix 'i' format handling in memory dump
@ 2010-02-21 14:23 Gleb Natapov
2010-02-22 9:51 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2010-02-21 14:23 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru
It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical)
when env is true.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/monitor.c b/monitor.c
index b1a6edc..19470d1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
int flags;
flags = 0;
env = mon_get_cpu();
- if (!is_physical)
- return;
#ifdef TARGET_I386
if (wsize == 2) {
flags = 1;
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] fix 'i' format handling in memory dump
2010-02-21 14:23 [Qemu-devel] [PATCH] fix 'i' format handling in memory dump Gleb Natapov
@ 2010-02-22 9:51 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2010-02-22 9:51 UTC (permalink / raw)
To: Gleb Natapov; +Cc: qemu-devel
Gleb Natapov <gleb@redhat.com> writes:
> It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical)
> when env is true.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/monitor.c b/monitor.c
> index b1a6edc..19470d1 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
> int flags;
> flags = 0;
> env = mon_get_cpu();
> - if (!is_physical)
> - return;
> #ifdef TARGET_I386
> if (wsize == 2) {
> flags = 1;
*Ouch*
I checked the offending commit for more such errors, but couldn't find
any.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-22 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-21 14:23 [Qemu-devel] [PATCH] fix 'i' format handling in memory dump Gleb Natapov
2010-02-22 9:51 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).