From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NjFDc-0001Jh-K6
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 12:03:44 -0500
Received: from [199.232.76.173] (port=53074 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NjFDc-0001JZ-85
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 12:03:44 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NjFDa-0005Ch-Ny
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 12:03:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50595)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NjFDa-0005Bq-3O
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 12:03:42 -0500
Date: Sun, 21 Feb 2010 19:00:21 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100221170021.GA5185@redhat.com>
References: <4B7821AC.6080400@mail.berlios.de>
	<1266164189-21062-1-git-send-email-weil@mail.berlios.de>
	<1266164189-21062-2-git-send-email-weil@mail.berlios.de>
	<1266164189-21062-3-git-send-email-weil@mail.berlios.de>
	<1266164189-21062-4-git-send-email-weil@mail.berlios.de>
	<1266164189-21062-5-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1266164189-21062-5-git-send-email-weil@mail.berlios.de>
Subject: [Qemu-devel] Re: [PATCH 05/20] eepro100: Add all supported devices
	to pci.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Sun, Feb 14, 2010 at 05:16:14PM +0100, Stefan Weil wrote:
> All eepro100 devices work with drivers which
> only use basic features.
> 
> They were tested with gpxe boot.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/pci.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index eb2043e..1ba3f92 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -1436,9 +1436,18 @@ void do_pci_info(Monitor *mon, QObject **ret_data)
>  
>  static const char * const pci_nic_models[] = {
>      "ne2k_pci",
> +    "i82550",
>      "i82551",
> +    "i82557a",
>      "i82557b",
> +    "i82557c",
> +    "i82558a",
> +    "i82558b",
> +    "i82559a",
> +    "i82559b",
> +    "i82559c",
>      "i82559er",
> +    "i82562",
>      "rtl8139",
>      "e1000",
>      "pcnet",
> @@ -1448,9 +1457,18 @@ static const char * const pci_nic_models[] = {
>  
>  static const char * const pci_nic_names[] = {
>      "ne2k_pci",
> +    "i82550",
>      "i82551",
> +    "i82557a",
>      "i82557b",
> +    "i82557c",
> +    "i82558a",
> +    "i82558b",
> +    "i82559a",
> +    "i82559b",
> +    "i82559c",
>      "i82559er",
> +    "i82562",
>      "rtl8139",
>      "e1000",
>      "pcnet",

One wonders: would it be cleaner to have a single eepro100 device
with specific model as qdev option?

-- 
MST