From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjMC4-0000Rc-3C for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:30:36 -0500 Received: from [199.232.76.173] (port=41482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjMC3-0000RN-Np for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:30:35 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjMC2-0002ks-VJ for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:30:35 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:5847) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjMC2-0002ko-K5 for qemu-devel@nongnu.org; Sun, 21 Feb 2010 19:30:34 -0500 Received: by fg-out-1718.google.com with SMTP id 22so28348fge.10 for ; Sun, 21 Feb 2010 16:30:32 -0800 (PST) From: Bartlomiej Zolnierkiewicz Date: Mon, 22 Feb 2010 01:28:20 +0100 References: <201002211025.11588.rob@landley.net> <20100221.155719.226789440.davem@davemloft.net> In-Reply-To: <20100221.155719.226789440.davem@davemloft.net> MIME-Version: 1.0 Message-Id: <201002220128.21067.bzolnier@gmail.com> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Commit 085219f79cad broke Sparc-32 back in 2.6.28. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, sam@ravnborg.org, atar4qemu@googlemail.com On Monday 22 February 2010 12:57:19 am David Miller wrote: > From: Rob Landley > Date: Sun, 21 Feb 2010 10:25:09 -0600 > > > 085219f79cad89291699bd2bfb21c9fdabafe65f is first bad commit > > commit 085219f79cad89291699bd2bfb21c9fdabafe65f > > Author: Sam Ravnborg > > Date: Fri Jan 2 18:47:34 2009 -0800 > > > > sparc32: use proper types in struct stat > > > > Like sparc64 use proper types in struct stat > > > > Signed-off-by: Sam Ravnborg > > Signed-off-by: David S. Miller > > > > This commit breaks stat and makes sparc32 essentially unusable. It changes > > the size of the various types in stat.h, and means that if you "mount -t tmpfs > > /tmp /tmp" and then try to ls /tmp, ls dies with a memory allocation error. > > > > I've confirmed that reverting it fixes the problem. > > Thanks for tracking this down Rob, I'll work on a fix and > push it around. Looking at how whole sparc32 has been apparently broken for over a year now because of a purely cleanup patch I wonder if it would be appropriate to make sparc32 into 'legacy only' and provide 'a stability promise' for it? Just an idea.. ;) -- Bartlomiej Zolnierkiewicz