From: Ryan Harper <ryanh@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm
Date: Tue, 23 Feb 2010 09:13:14 -0600 [thread overview]
Message-ID: <20100223151314.GN17350@us.ibm.com> (raw)
Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M memsize.
This patch adds a simple check and error message (much like the 2047 limit on
32-bit hosts) on ram_size in the control path after we determine we're
not using kvm
Upstream qemu-kvm is affected if using the -no-kvm option; this patch address
the segfault there as well.
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
vl.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index db7a178..a659e98 100644
--- a/vl.c
+++ b/vl.c
@@ -5760,6 +5760,12 @@ int main(int argc, char **argv, char **envp)
fprintf(stderr, "failed to initialize KVM\n");
exit(1);
}
+ } else {
+ /* without kvm enabled, we can only support 4095 MB RAM */
+ if (ram_size > (4095UL << 20)) {
+ fprintf(stderr, "qemu: without kvm support at most 4095 MB RAM can be simulated\n");
+ exit(1);
+ }
}
if (qemu_init_main_loop()) {
--
1.6.3.3
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
next reply other threads:[~2010-02-23 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 15:13 Ryan Harper [this message]
2010-02-23 17:02 ` [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm Aurelien Jarno
2010-02-23 20:30 ` Alexander Graf
2010-02-23 21:07 ` Anthony Liguori
2010-02-23 21:24 ` Aurelien Jarno
2010-02-23 22:55 ` Ryan Harper
2010-03-04 21:27 ` Aurelien Jarno
2010-03-04 21:34 ` Ryan Harper
2010-03-06 21:31 ` Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 18:01 Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223151314.GN17350@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).