From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nk3i1-0004kc-Nc for qemu-devel@nongnu.org; Tue, 23 Feb 2010 17:58:29 -0500 Received: from [199.232.76.173] (port=56473 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nk3i1-0004kK-8b for qemu-devel@nongnu.org; Tue, 23 Feb 2010 17:58:29 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nk3hz-0007ag-Si for qemu-devel@nongnu.org; Tue, 23 Feb 2010 17:58:29 -0500 Received: from hall.aurel32.net ([88.191.82.174]:42721) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nk3hz-0007aa-Gb for qemu-devel@nongnu.org; Tue, 23 Feb 2010 17:58:27 -0500 Date: Tue, 23 Feb 2010 23:58:25 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 0/6] target-alpha: fpu qualifiers, round 2 Message-ID: <20100223225825.GS10348@hall.aurel32.net> References: <4B2BFD85.6070702@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: laurent.desnogues@gmail.com, qemu-devel@nongnu.org On Mon, Jan 04, 2010 at 02:46:05PM -0800, Richard Henderson wrote: > I've split up the FPCR as requested by Aurelien. We no longer > set anything in FP_STATUS after the execution of the operation, > only copy data from FP_STATUS to some env->fpcr field. > > I have totally rewritten the patch to be more along the line > that Laurent was suggesting, in that the rounding mode and other > qualifiers are totally parsed within the translator. I no longer > pass the FN11 field to the helper functions. > What's the benefit of doing that? I don't say it's wrong, I just want to understand. Otherwise the patch looks good, so it can probably be applied without any change. In the meanwhile, I have applied patches 1 to 5. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net