From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nk6zW-0002aT-TC for qemu-devel@nongnu.org; Tue, 23 Feb 2010 21:28:46 -0500 Received: from [199.232.76.173] (port=53120 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nk6zV-0002aF-Ii for qemu-devel@nongnu.org; Tue, 23 Feb 2010 21:28:45 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nk6zT-0002rD-7M for qemu-devel@nongnu.org; Tue, 23 Feb 2010 21:28:45 -0500 Received: from mx20.gnu.org ([199.232.41.8]:56387) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nk6zT-0002r7-16 for qemu-devel@nongnu.org; Tue, 23 Feb 2010 21:28:43 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nk6zR-00087p-KD for qemu-devel@nongnu.org; Tue, 23 Feb 2010 21:28:41 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [RFC] Don't send local debug output to stdout (was: pm_smbus: remove #ifdef DEBUG) Date: Wed, 24 Feb 2010 02:28:31 +0000 References: <1262745591-28697-1-git-send-email-yamahata@valinux.co.jp> <20100106235113.GE29412@valinux.co.jp> <4B53363C.8060906@mail.berlios.de> In-Reply-To: <4B53363C.8060906@mail.berlios.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002240228.31814.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Isaku Yamahata > I suggest these steps: > > 1. Debug output to stdout is no longer accepted for new / modified code. > > 2. New or modified debug messages should go to stderr. I don't see this as a real improvement. Arguably these aren't errors, so stdout is where they should be going. If we're going to do anything sensible with debug output then we should figure out how to do it properly and consistently. Also remember that this isn't supposed to be user friendly, it's for internal developer use only. Paul