From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nkc8V-0003nf-Db
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:44:07 -0500
Received: from [199.232.76.173] (port=37624 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nkc8V-0003nV-3l
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:44:07 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1Nkc8T-0000So-U2
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:44:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7421)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1Nkc8T-0000Se-DI
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:44:05 -0500
Date: Thu, 25 Feb 2010 13:40:49 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100225114048.GB9116@redhat.com>
References: <f43fc5581002181107w7bb19d2cye08e931b6401d4db@mail.gmail.com>
	<1266524723-21572-1-git-send-email-pbonzini@redhat.com>
	<1266524723-21572-2-git-send-email-pbonzini@redhat.com>
	<f43fc5581002181328x31d0ab1l7ab09fa530c24781@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <f43fc5581002181328x31d0ab1l7ab09fa530c24781@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v2 2/2] get rid of hostregs_helper.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Thu, Feb 18, 2010 at 11:28:14PM +0200, Blue Swirl wrote:
> > =A0 =A0 /* restore global registers */
> > -#include "hostregs_helper.h"
> > + =A0 =A0asm("");
> > + =A0 =A0env =3D (void *) saved_env_reg;
> >

Is this sufficient?
I see __asm__ __volatile__("": : :"memory") in virtio.
Is memory clobber implied? What about volatile?

--=20
MST