From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NkcEd-00057Q-C9
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:50:27 -0500
Received: from [199.232.76.173] (port=60398 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NkcEc-000578-WA
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:50:27 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NkcEW-0000lD-7I
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:50:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41922)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NkcEU-0000l1-JV
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:50:19 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PBoH2J031662
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Feb 2010 06:50:17 -0500
Date: Thu, 25 Feb 2010 13:47:03 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100225114703.GD9116@redhat.com>
References: <m3iq9lvcjr.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3iq9lvcjr.fsf@blackfin.pond.sub.org>
Subject: [Qemu-devel] Re: [PATCH] scsi: Make device scsi-disk reject /dev/sg*
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Thu, Feb 25, 2010 at 11:23:52AM +0100, Markus Armbruster wrote:
> You're supposed to use scsi-generic for that.  Which rejects anything
> but /dev/sg*.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/scsi-disk.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index b2f61fe..ad8eb24 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -1027,6 +1027,11 @@ static int scsi_disk_initfn(SCSIDevice *dev)
>      }
>      s->bs = s->qdev.conf.dinfo->bdrv;
>  
> +    if (bdrv_is_sg(s->bs)) {
> +        qemu_error("scsi-disk: unwanted /dev/sg*\n");
> +        return -1;

Can we make the error message a bit more verbose?
E.g. "scsi-disk does not support /dev/sg*, please use *** instead".
Where *** tells user what to do.

> +    }
> +
>      if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM) {
>          s->cluster_size = 4;
>      } else {
> -- 
> 1.6.6
> 
>