From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NkcVL-0002Cu-MQ
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 07:07:43 -0500
Received: from [199.232.76.173] (port=39246 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NkcVL-0002Ce-8z
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 07:07:43 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <mst@redhat.com>) id 1NkcVK-0001fN-18
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 07:07:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3288)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NkcVJ-0001fH-M0
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 07:07:41 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PC7ev2018087
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Feb 2010 07:07:40 -0500
Date: Thu, 25 Feb 2010 14:04:27 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100225120427.GG9116@redhat.com>
References: <1267098884-5103-1-git-send-email-amit.shah@redhat.com>
	<1267098884-5103-2-git-send-email-amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1267098884-5103-2-git-send-email-amit.shah@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/2] virtio-pci: Use
	DEV_NVECTORS_UNSPECIFIED instead of -1 for virtio-serial
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Feb 25, 2010 at 05:24:44PM +0530, Amit Shah wrote:
> Use the named constant instead of -1.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> Reported-by: "Michael S. Tsirkin" <mst@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/virtio-pci.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index bcd40f7..799f664 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -500,8 +500,9 @@ static int virtio_serial_init_pci(PCIDevice *pci_dev)
>      if (!vdev) {
>          return -1;
>      }
> -    vdev->nvectors = proxy->nvectors == -1 ? proxy->max_virtserial_ports + 1
> -                                           : proxy->nvectors;
> +    vdev->nvectors = proxy->nvectors == DEV_NVECTORS_UNSPECIFIED
> +                                        ? proxy->max_virtserial_ports + 1
> +                                        : proxy->nvectors;
>      virtio_init_pci(proxy, vdev,
>                      PCI_VENDOR_ID_REDHAT_QUMRANET,
>                      PCI_DEVICE_ID_VIRTIO_CONSOLE,
> @@ -585,7 +586,8 @@ static PCIDeviceInfo virtio_info[] = {
>          .init      = virtio_serial_init_pci,
>          .exit      = virtio_exit_pci,
>          .qdev.props = (Property[]) {
> -            DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, -1),
> +            DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
> +                               DEV_NVECTORS_UNSPECIFIED),
>              DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
>              DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
>              DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, max_virtserial_ports,
> -- 
> 1.6.2.5
> 
>