From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nl67B-0003U1-J6
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:45 -0500
Received: from [199.232.76.173] (port=54017 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nl67A-0003Td-Qu
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:44 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <lcapitulino@redhat.com>) id 1Nl678-0006zP-FI
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:44 -0500
Received: from mx20.gnu.org ([199.232.41.8]:41206)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <lcapitulino@redhat.com>)
	id 1Nl677-0006yA-Rk
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:42 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1Nl66d-0003Re-OW
	for qemu-devel@nongnu.org; Fri, 26 Feb 2010 14:44:12 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QJi2Yh029995
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Feb 2010 14:44:02 -0500
Date: Fri, 26 Feb 2010 16:43:54 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC 12/48] error: New error_printf() and
	error_vprintf()
Message-ID: <20100226164354.6be8466d@redhat.com>
In-Reply-To: <1267034160-3517-13-git-send-email-armbru@redhat.com>
References: <1267034160-3517-1-git-send-email-armbru@redhat.com>
	<1267034160-3517-13-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 24 Feb 2010 18:55:24 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> FIXME They should return int, so callers can calculate width.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qemu-error.c |   49 ++++++++++++++++++++++++++++++++++++++++++-------
>  qemu-error.h |   14 ++++++++++++++
>  2 files changed, 56 insertions(+), 7 deletions(-)
> 
> diff --git a/qemu-error.c b/qemu-error.c
> index 63bcdcf..76c660a 100644
> --- a/qemu-error.c
> +++ b/qemu-error.c
> @@ -1,18 +1,53 @@
> +/*
> + * Error reporting
> + *
> + * Copyright (C) 2010 Red Hat Inc.
> + *
> + * Authors:
> + *  Markus Armbruster <armbru@redhat.com>,
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
>  #include <stdio.h>
>  #include "monitor.h"
>  #include "sysemu.h"
>  
> -void qemu_error(const char *fmt, ...)
> +/*
> + * Print to current monitor if we have one, else to stderr.
> + * FIXME should return int, so callers can calculate width, but that
> + * requires surgery to monitor_printf().  Left for another day.
> + */
> +void error_vprintf(const char *fmt, va_list ap)
>  {
> -    va_list args;
> -
> -    va_start(args, fmt);
>      if (cur_mon) {
> -        monitor_vprintf(cur_mon, fmt, args);
> +        monitor_vprintf(cur_mon, fmt, ap);
>      } else {
> -        vfprintf(stderr, fmt, args);
> +        vfprintf(stderr, fmt, ap);
>      }
> -    va_end(args);
> +}

 This can be static.

> +
> +/*
> + * Print to current monitor if we have one, else to stderr.
> + * FIXME just like error_vprintf()
> + */
> +void error_printf(const char *fmt, ...)
> +{
> +    va_list ap;
> +
> +    va_start(ap, fmt);
> +    error_vprintf(fmt, ap);
> +    va_end(ap);
> +}

 This function's name is inconsistent with qemu_error() and
qemu_error_new().